- I failed to use Hungarian notation in a few places. (Hungarian notation is things like szText for "null-termated string Text" and ppvFiles for "pointer to a pointer of a vector of Files," for those of you who have only been coding this century or never at all.)
- If statements and the "then" condition can never be on the same line. Never. You can't have "if (bExit) return;"—you have to waste two lines for this. Never mind that wasted vertical space makes you lose context and hurts the flow of the text.
- Spaces instead of tabs in one particular area of the product. This is because the command prompt tabstops are at 8 characters, not 4, and some people use things like vi to edit and view source files. It sounds like we're changing to all tabs everywhere soon, though... that's something, I guess.
- Lines wrapped to 80 characters. I think this one hurt the most, because some lines had to be wrapped absurdly. Word wrap has been invented. All of our screens are 1600x1200. There is no reason to break lines at an arbitrary limit. If you must break lines because every code editor's word wrap is stupid, do it at a good place, not just because you've already typed 75 characters and your next word is six characters. This is retarded. I will not back down on this. It will always be retarded.
- I put the asterisk after the type name, not the variable name. This one I wasn't made to change. But, dammit, it's a wide char pointer, not a wide character-and-oh-look-it-also-happens-to-be-a-pointer. (I like "wchar* szText"; he likes "wchar *szText". When surrounded in code, I find the first one infinitely easier to read at a glance.)
It was a long process. This review and the final round of pre-checkin testing has been going on for the whole last week, and by the end, we were both having to try very hard to remain civil and professional, because I still disagree with a lot of what he says. I'm sure he felt at some point like I'm an arrogant prick... like, "here's someone who hasn't even been on the team for a year, with lines in excess of 100 characters (!) that use up a full half of the width of the screen, and he's disagreeing with me on technical issues." But, oh well. It's over. Wounds will heal. No more 60+-hour weeks for a long time, I think. I got to watch a couple movies and play Warcraft on Saturday and Monday, only working partial days then. Out of my three-day weekend, I got a total of a day or maybe even a day and a half of relaxation.